wefork / wekan

The open-source Trello-like kanban (built with Meteor)
https://wekan.io
MIT License
61 stars 12 forks source link

Add checklist feature #83

Closed lkisme closed 7 years ago

lkisme commented 7 years ago

Made a quick PR on wefork code base, will continue to test and refine the code, hope this will help. The diff is identical with PR https://github.com/wekan/wekan/pull/630

whittssg commented 7 years ago

@lkisme When testing this I (and a few others) noticed that we couldn't get the Checklist Name edits to stick nor Checklist item edits to stick.

Adding the following in the checklists.jade file seemed to work:

Line 14: +inlinedForm(classNames="js-edit-checklist-title" checklist = checklist) added checklist=checklist Line 46: +inlinedForm(classNames="js-edit-checklist-item" item = item checklist = checklist) added item = item checklist = checklist

Thanks.

jeremykraft commented 7 years ago

I can't seem to "check" any of the items on the lists I create. Everything else works (create lists, add items, delete, etc...) now that I've made the two changes to checklists.jade as suggested by @whittssg ... Any ideas?

whittssg commented 7 years ago

@jeremykraft Did you include this at the bottom of your checklists.js:

BlazeComponent.extendComponent({ toggleItem() { const checklist = this.currentData().checklist; const item = this.currentData().item; if (checklist && item && item._id) { checklist.toggleItem(item._id); } }, events() { return [{ 'click .item .check-box': this.toggleItem, }]; }, }).register('itemDetail');

jeremykraft commented 7 years ago

I did not... But that fixed it! Thank you! Where did that come from?...

whittssg commented 7 years ago

@jeremykraft Its on the original PR.. not sure why it didnt make it to this one.

brylie commented 7 years ago

@lkisme, will you please update this PR to fix the above issue?

Serubin commented 7 years ago

Was the issue fixed?

@xet7 Can we merge this guy in assuming the issue was fixed.