search

weglide / bugtracker

WeGlide platform bug tracker.
https://www.weglide.org
11 stars 1 forks source link

Date formats displayed, UK English #106

Closed DecisionNumerics closed 3 years ago

DecisionNumerics commented 3 years ago

Would be great if with language selection "English" the English date format was applied, DD-MM-YYYY, rather than the American date format (MM/DD/YYYY).

samuel-git commented 3 years ago

Good point. Then we need two different language settings or an additional selection in the user settings.

moldhouse commented 3 years ago

Backend already supports language setting in the profile section.

samuel-git commented 3 years ago

I would rather handle language on a per-device level like it currently is:

  1. check if user has already done a selection on this device
  2. fallback to browser/OS language
  3. fallback to english

I naively assumed that date format can be language dependent. This works only if we distinguish EN and US english. Date formats are also not unit dependent I guess.

Apropos units, UK uses km for competition flying afaik. So we need an extra unit setting "UK".

samuel-git commented 3 years ago

I think keeping the language <--> date format relation is okay but then we need to introduce English US and English GB: https://en.wikipedia.org/wiki/Date_format_by_country

DecisionNumerics commented 3 years ago

Nice fix! Many thanks.