weglide / bugtracker

WeGlide platform bug tracker.
https://www.weglide.org
11 stars 0 forks source link

Improve/fix ENL coloring in barogram #56

Closed niggli closed 3 years ago

niggli commented 3 years ago

Describe the bug When I upload a flight and the type of glider is a motorglider from the beginning, the time during engine run is yellow in the barogram. If I edit a flight because the type of glider was entered as a pure glider, and then change it to a motorglider, the ENL is not shown.

To Reproduce Steps to reproduce the behavior:

  1. Upload flight with engine run
  2. Select "ASG 29 18m" as glider type and save
  3. Edit this flight and change type to "ASG29 E 18m"
  4. See error

Expected behavior The barogram should always be yellow during engine run. Additionally, for the selection of the correct "Wertungsfenster" it would really help to be able to already see a small map view, especially if the flight has multiple engine runs.

Screenshots

Bildschirmfoto 2021-01-03 um 23 16 44

Device (please complete the following information):

samuel-git commented 3 years ago

57 is related.

Proposal: make ENL switchable with a second tab like airspaces (and fix this bug). What do you think?

Dimowelle commented 3 years ago

ENL should not be switchable and should always for everybody be visible, because there are too many Guys cheating and I want direct to see possible missbehaviour ... I am very sad about that sportsmen - not only for competition, but simply for easy comparison. Everybody have to control their gliding window.

By default I appreciate a Low noise level, so the gliding windows gets smaller and the pilot have to choose and edit the window. For komfort the glide start and end time should be clickable in the window-area, maybe with a sliding function. I ever have to adjust the correct start and end time, so a low noise level is no problem.

niggli commented 3 years ago

I agree, it should always be visible or at least per default visible.

samuel-git commented 3 years ago

@Dimowelle @niggli it's online but off on default. This decision is not final but I think especially on mobile the baro becomes too cluttered with 3 different time-series. Also the axes become unclear.

For scoring window adjustment in the barogram directly, we had it this way first but decided against it because of mobile/small devices. It's just not possible to zoom, zoom the barogram drag the barogram and drag the scoring window on smaller touch screens. I'm open to better ideas, as I agree that thats not the friendliest UX way.

niggli commented 3 years ago

Thanks, works for me!

If I really have to check and adjust my scoring window, in the last years I always had to open the flight in another tool which had a map for, example SeeYou. I then wrote the exact timestamp on a piece of paper and edited it in OLC. Having just the barogram, it's often not possible to be sure if the algorithm has found the correct moment of tow release. So ideally I would be able to look at a very zoomed in map of the scoring window boundaries directly in weglide when claiming/editing a flight. But of course that would also be a bit of an overload for mobile devices.

Coloring the flight track in another color during engine use could also be a good idea, like LXNAV does in their flight computers.

Dimowelle commented 3 years ago

Thank you, works also for me :-)

Only coloring the flight-track is not so good, because the amount of noise-level gets lost. The implemented way now is the better way - for me.

A simple idea for easy adjustment of the scoring window - using both methods: manually edit in the fields Start/End OR click in Start and then Click in the window, so that the time from the window appears in the Start-field. (analog for End-time). This is a similar way as booking in booking.com.

Congratulation for the very good implementation of multiple choices for gliding windows:

Thank you!

samuel-git commented 3 years ago

Will close this issue and come back when we have a good idea for the scoring edit. Thanks for the input and discussion!