Closed frantzheld closed 3 years ago
If I split the rectangle in two triangles, you can see that both are valid DMSt triangles.
Btw: Displaying the valid sector as well for rectangles would help a lot for planning. The sectors for both turnpoints of the shared leg have to be constructed as an overlap of both triangle sectors for the respective turnpoint. In this example I marked them in yellow. The shape gets a bit strange, but should be valid.
@samuel-git could we draw both triangle sectors and then see only mark the overlap on the map. This would be much simpler than calculating the edges of the rectangle sectors.
This is possible with https://turfjs.org/docs/#intersect. My concern is the real time performance as tur is notoriously slow.
Can you confirm that the problem is fixed for your task?
Yes, thank you!
Closed, as original issue is fixed. Feel free to reopen/rename if you have some time for the rectangle sector drawing :)
Describe the bug Task scoring calculation may be wrong when starting a rectangle on leg. A correct rectangle is not scored as such.
To Reproduce Steps to reproduce the behavior:
Expected behavior As both tasks are identical (except for the start), they should both been scored identical (as rectangle).
Screenshots Start on the edge: Scored as declared rectangle![image](https://user-images.githubusercontent.com/47079209/107686513-9e874180-6ca5-11eb-9a2a-8038c6a2c645.png)
Start on leg: Scored as free![image](https://user-images.githubusercontent.com/47079209/107686552-aba43080-6ca5-11eb-9e37-86e3863b7061.png)