search

wegue-oss / wegue

Template and components for webmapping applications with OpenLayers and Vue.js
BSD 2-Clause "Simplified" License
97 stars 42 forks source link

Additional HTTP params for WMS layers #306

Closed chrismayer closed 1 year ago

chrismayer commented 1 year ago

This adds the optional config option params for 'TILEWMS'and 'IMAGEWMS' layers. This allows to inject custom HTTP parameters to the GetMap request of the layer.

This is useful to set custom (non-standardized) WMS request parameters, such as CQL_FILTER or FEATUREID, which are e.g. supported by the GeoServer WMS implementation or the angle parameter of the UMN Mapserver software.

fschmenger commented 1 year ago

@chrismayer: Nice job! This has also been on my TODO list for quite some time. From looking at the code this looks good, but didnt have any time to give it a test run yet. imo for the sake of simplicity you could just name the new attribute params, but that`s a matter of taste.

chrismayer commented 1 year ago

Thanks for your review @fschmenger . I agree that using params for simplicity would be better. I adapted my changeset in e2a7a62 . Would you please have another short look and approve the PR so I can merge? Thanks in advance.

chrismayer commented 1 year ago

Great! Thanks again @fschmenger!