search

wegue-oss / wegue

Template and components for webmapping applications with OpenLayers and Vue.js
BSD 2-Clause "Simplified" License
93 stars 41 forks source link

Changed deprecated slot syntax #360

Closed sronveaux closed 4 months ago

sronveaux commented 7 months ago

In the wake of #359 there is a small PR which gets rid of the slot and slot-scope attributes which are strongly discouraged since Vue 2.6 and deprecated in Vue 3.

This PR was made as a small step towards #350 and #351 and is in fact the preliminary step before migrating to Vue 3 as stated in the official migration guide.

This should have no impact on any working Wegue application as deprecated syntax can still be used next to the new one but it should be tested on bigger and more complete apps just to be sure...

fschmenger commented 7 months ago

Hi @sronveaux, thanks a lot for providing this! I`m unfortunately a bit short currently for a full review but will do either in the upcoming weeks or maybe @chrismayer can?!

Do the commits 607c6a3373d5fa62918914ad1ce25c549b815903 and 49ea5f30f7c666397e25ceeba83b18a45df42a9c relate to slot syntax changes? Maybe you should either change the title of this PR to something more general like "maintenance" or rather split it up into 2 separate PRs (can be nested).

Greets Felix

sronveaux commented 7 months ago

Hi @fschmenger and thanks for the comment, no problem, there is no hurry, this will be useful later when updating to Vue3 but it has no other purpose...

Concerning the two commits, it was kind of linked because when updating the workshop documentation with the new syntax, I came across the fact that the workshop code couldn't be run anymore because of linting errors. So it was no point to change just the slot syntax but have a code that can't be run on current version of Wegue...

No problem, this PR now just changes the slot syntax in code and documentation and I'm going to create another PR with the updates to the workshop...

Greets, Sébastien