Remove non-effective color prop in ToggleButton

wegue-oss / wegue

Template and components for webmapping applications with OpenLayers and Vue.js

BSD 2-Clause "Simplified" License

93 stars 41 forks source link

Remove non-effective color prop in ToggleButton #399

Closed chrismayer closed 4 weeks ago

chrismayer commented 1 month ago

This removes non-effective color prop definition in the ToggleButton component.

fschmenger commented 1 month ago

Maybe add @ntma as a reviewer and wait until he is around? A lot of work and testing went into theming, so rather be sure there are no unintended side effects.

chrismayer commented 1 month ago

I just added the correction due to review comment by @sronveaux. Could you please give it another view and approve if you're happy now?

chrismayer commented 4 weeks ago

Thanks for your additional review @sronveaux. I am going to merge now, since I don't expect any problems by this changeset. @ntma If I am wrong, please comment here (even after merging) and I'll happily come up with separate PR.