wehs7661 / ensemble_md

A python package for performing GROMACS simulation ensembles
MIT License
13 stars 4 forks source link

MT-REXEE development #58

Closed wehs7661 closed 2 weeks ago

wehs7661 commented 1 month ago

Merge PR-57 into the master branch to incorporate final tweaks and updates based on the original Anika's pull request (#57). Here is a checklist for the PR to be merged:

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 97.45127% with 17 lines in your changes missing coverage. Please review.

Project coverage is 96.00%. Comparing base (9958558) to head (98af948). Report is 77 commits behind head on master.

Files with missing lines Patch % Lines
ensemble_md/utils/coordinate_swap.py 97.87% 11 Missing :warning:
ensemble_md/replica_exchange_EE.py 96.90% 3 Missing :warning:
ensemble_md/utils/gmx_parser.py 94.33% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #58 +/- ## ========================================== + Coverage 95.51% 96.00% +0.48% ========================================== Files 10 11 +1 Lines 1919 2576 +657 ========================================== + Hits 1833 2473 +640 - Misses 86 103 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wehs7661 commented 1 month ago

Hey @ajfriedman22 I have just closed #57 and #58, so we can just keep throwing everything about MT-REXEE into this PR (e.g., unit tests, or any necessary tweaks for the core functionalities). For documentation for MT-REXEE, it might be better to have a separate branch for it, so we can prioritize merging this into the master branch. Also, it would be great if you could help resolve the linting and CI errors. You can find more information in the contributing guidelines: https://github.com/wehs7661/ensemble_md/blob/master/CONTRIBUTING.md