wei-mao-2019 / HisRepItself

104 stars 19 forks source link

Question about the 3D keypoint generation for H36M / Potential bugs for training and testing #8

Closed dulucas closed 2 years ago

dulucas commented 2 years ago

Hi Wei,

I have a question about the way you generate the 3D keypoints xyz coordinates from the expmaps. As shown in this line this, all keypoints are calculated by the keypoint coordinate from the first frame p3d[0, i, :], which will generate errornous GTs(unless there is only 1 frame or batch_size=1, but in your dataloader this is not the case)

I think this line should be changed to

p3d[:, i, :] = torch.matmul(R[:, parent[i], :, :], p3d[:, i, :].unsqueeze(-1)).squeeze() + p3d[:, parent[i], :]

?

Or did I miss something? Best