search

wei-yutong / pe

0 stars 0 forks source link

Duplicate identical appointments can be added #3

Open wei-yutong opened 3 years ago

wei-yutong commented 3 years ago

Appointments with the exact same date and time are not recognized as duplicates, and show up as multiple instances of the appointment. No error message is thrown to stop the user from adding a duplicate.

Steps to reproduce:

  1. appt 1 d/24051800
  2. appt 1 d/24051800
  3. appt 1 d/24051800

Below is the screenshot:

Screenshot 2021-04-16 at 2.27.08 PM.png

nus-pe-bot commented 3 years ago

Team's Response

We appreciate the feedback and think this is a good feature to add, but we dont see this as a bug since we did not claim to check for duplicates in the appointment.

In fact, our team has considered many things to check for during the creation of an appointment, such as duplicates as you have mentioned, unlikely timings for appointments (think 12am on a saturday morning), etc. but decided to only implement the most detrimental mistake during appointment creation which is adding a date that is already past. (we had other more important features to implement)

We dont really view this as a bug and it is out of our scope

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: Simply stating that you "did not claim to check for duplicates in the appointment" does not justify it not being a bug; it shows that you did not consider the case where the user could add repeated appointments. I could simply counter it by saying "but you did not not claim to check for duplicates in the appointment". There was no explicit statement that duplicates COULD be added either, and hence I think that it was a reasonable user behaviour to test.

Your application is meant for doctors to manage their patients' data, and it is very possible for the doctor to accidentally add multiple identical appointments out of forgetfulness or carelessness. This is displayed as "3 scheduled appointments" as per my screenshot in the bug report, which is very misleading for the doctor and defeats the purpose of having an app to streamline data management and scheduling.

I understand that unlikely timings for appointments are considered as an additional feature your team is looking into, but checking for identical appointments should have been tackled in this stage as it is rather important to the functioning of your app for your target users.

I do not agree with the rejection of my bug report.