wei / socialify

πŸ’ž Socialify your project. 🌐 Share with the world!
http://socialify.git.ci
MIT License
1.87k stars 106 forks source link

:bug: Fetch will never throw error when status code is not ok #344

Closed soxft closed 2 months ago

soxft commented 2 months ago

343 https://github.com/wei/socialify/issues/343

changeset-bot[bot] commented 2 months ago

πŸ¦‹ Changeset detected

Latest commit: 79a0807624f369201c33860035c138ba79508893

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------- | ----- | | socialify | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

wei commented 2 months ago

Thanks for the PR, looks great! Please add changeset and we can get it merged!

netlify[bot] commented 2 months ago

Deploy Preview for github-socialify ready!

Name Link
Latest commit 79a0807624f369201c33860035c138ba79508893
Latest deploy log https://app.netlify.com/sites/github-socialify/deploys/66dbd198aaa0f00008211a8e
Deploy Preview https://deploy-preview-344--github-socialify.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

soxft commented 2 months ago

Sorry, I have limited experience using changesets. I followed the tutorial mentioned above to make the corresponding additions, but I'm not sure if I did it correctly

wei commented 2 months ago

Sorry, I have limited experience using changesets. I followed the tutorial mentioned above to make the corresponding additions, but I'm not sure if I did it correctly

Looks perfect! Tyvm will review and merge ☺️