search

weichch / system-text-json-jsondiffpatch

High-performance, low-allocating JSON object diff and patch extension for System.Text.Json. Support generating patch document in RFC 6902 JSON Patch format.
MIT License
104 stars 13 forks source link

Add SourceLink support to package #42

Open matracey opened 11 months ago

matracey commented 11 months ago

New features and updates

522be95 add debug symbols and explicit packable configuration to src/Directory.build.props f1fd5d7 add explicit SourceLink.GitHub package reference 31bd648 add msbuild properties for SourceLink e72126c upgrade packages to latest versions

Project structure enhancements

558b8cb move sln file up to project root f616e41 add missing loose items to sln file f4ef2d5 add recommended VS Code extensions to extensions.json 8cecd49 update gitignore using dotnet new gitignore 7b1e292 add global.json with SDK version configuration d554044 add IsTestProject property to Directory.Build.props for test folder 5ea3667 update AssemblyVersion and FileVersion to use JsonDiffPatchPackageVersion

matracey commented 11 months ago

@weichch Are you still maintaining this package? Happy to take it over if not.

weichch commented 11 months ago

@weichch Are you still maintaining this package? Happy to take it over if not.

Hi @matracey yes I’m still maintaining this package. I’m on holiday for a few weeks will take a look once I’m back. Thanks for the PR btw.

weichch commented 9 months ago

I cherry picked some of the changes in this PR into #43 as co-authored commit. Let's keep this PR open for addressing VS Code support if you wish.

I also found Microsoft has added two new methods in .NET 8 JsonNode.DeepEquals and JsonNode.DeepClone. Those methods are conflicting with the extension methods in this package as per mentioned in #4, and I will take a look at how to address those. Meanwhile, those methods don't seem to exist in .NET 6 and .NET 7.