Fixes so repo builds with Xcode 15

weichsel / ZIPFoundation

Effortless ZIP Handling in Swift

MIT License

2.34k stars 262 forks source link

Fixes so repo builds with Xcode 15 #283

Closed JagCesar closed 1 year ago

JagCesar commented 1 year ago

This PR Adds the os(xrOS) conditional check, without it the build fails as it falls into the #else block.

This is required to build with Xcode 15 beta 6

osy commented 1 year ago

FYI os(xrOS) does not work since beta 4. It should be os(visionOS). See https://github.com/weichsel/ZIPFoundation/compare/development...osy:ZIPFoundation:development

JagCesar commented 1 year ago

FYI os(xrOS) does not work since beta 4. It should be os(visionOS). See development...osy:ZIPFoundation:development

I don't think that's correct, I'm building one of our products using my fork and it builds, archives and uploads to App Store Connect without issues. Building on Xcode Cloud using Xcode beta 6. 🤷‍♂️

osy commented 1 year ago

I’m on beta 5 so maybe it’s a recent change? Regardless Apple is sticking to visionOS as marketing and changed all their API headers to refer to visionOS. I don’t think people should refer to xrOS.

weichsel commented 1 year ago

@JagCesar Thanks for the PR! I think @osy is right - Apple switched to visionOS for conditional compilation. Will merge and then change that on development.