weichsel / ZIPFoundation

Effortless ZIP Handling in Swift
MIT License
2.3k stars 253 forks source link

When I try to iterate over the entries of the attached file, nothing happens #318

Open JetForMe opened 3 months ago

JetForMe commented 3 months ago

Summary

The attached .3mf file is a zip archive with this directory structure:

GO-M8010-6-P1 copy
├── 3D
│   └── 3dmodel.model
├── [Content_Types].xml
└── _rels

I'm able to partially inspect this

let archive = Archive(ur: url, accessMode: .read)
print(archive.totalNumberOfEntriesInCentralDirectory)         // prints "3"

But I can’t enumerate those top level items:

for entry in archive {
    print("Entry: \(entry)")
}

Prints nothing. Attempting to get archive["3D"] returns nil.

Version 0.9.19

I had to zip the file to get Github to accept it. Unzip it, then try to load the resulting file using Arhive().

GO-M8010-6-P1.3mf.zip

weichsel commented 3 months ago

I can reproduce the issue with the archive you provided.
Currently, I don't have the capacity to investigate/fix this. So far, I found that the archive is using the ZIP64 extensions (which ZIPFoundation supports). But for some reason, it's obtaining wrong offsets from the ZIP64 structure that describes the entries. Due to the wrong offsets, creating an iterator for the entries fails.

Since extraction with the macOS built-in archive utility succeeds and also unzip -t doesn't report any errors, I suppose the archive metadata contains some edge cases that currently aren't not covered by ZIP Foundation's ZIP64 support.

If you want to have a look yourself, a good starting point would be Archive.makeIterator & CentralDirectoryStructure.effectiveRelativeOffsetOfLocalHeader.