We cut-over to inline functions that retrieve a BytePtr or ConstBytePtr from a std::string. The function handles the casts and asserts so we don't have to use the pattern throughout the code.
We are catching some asserts in Debug builds that we could sidestep. The current code in datatest.cpp uses a BytePtr, but it could use a ConstBytePtr like shown below (from around line 285):
We cut-over to inline functions that retrieve a
BytePtr
orConstBytePtr
from astd::string
. The function handles the casts and asserts so we don't have to use the pattern throughout the code.We are catching some asserts in Debug builds that we could sidestep. The current code in
datatest.cpp
uses aBytePtr
, but it could use aConstBytePtr
like shown below (from around line 285):This will track the change.