weigao95 / surfelwarp

SurfelWarp: Efficient Non-Volumetric Dynamic Reconstruction
https://sites.google.com/view/surfelwarp/home
BSD 3-Clause "New" or "Revised" License
276 stars 71 forks source link

Pangolin installation version specification for cilantro_build.md #74

Open WangYixuan12 opened 2 years ago

WangYixuan12 commented 2 years ago

Hi! Thanks for your great documentation! After following cilantro installation instructions, I found git clone from Pangolin does not work. The newest Pangolin cannot be included using Pangolin_INCLUDE_DIRS, as used in cilantro CMakeLists.txt. I found Pangolin v6.0 can work perfectly. Maybe you could specify the version in the documentation.

WangYixuan12 commented 2 years ago

Another suggestion: I think now modern cilantro is supported. You may change it in cilandro_build.md

shaisung commented 2 years ago

Another suggestion: I think now modern cilantro is supported. You may change it in cilandro_build.md

Note that as of August 2021, cilantro uses C++17 features: https://github.com/kzampog/cilantro/commit/02bc24046a96a839b09afe6b95b1466a7a7aee1c

And hence requires CUDA11.

I just banged my head against that for a few days trying to compile with CUDA10.1...