Disabled default behaviour for raising warnings

weigertlab / spotiflow

Accurate and efficient spot detection for microscopy data

BSD 3-Clause "New" or "Revised" License

51 stars 7 forks source link

Disabled default behaviour for raising warnings #6

Closed ajinkya-kulkarni closed 6 months ago

ajinkya-kulkarni commented 6 months ago

Every time I ran the inference, the warnings used to pop up, which were a) annoying and b) cluttered the terminal output.

AlbertDominguez commented 6 months ago

Hi @ajinkya-kulkarni ,

Thanks for the patch(es)! I totally agree it's annoying. I'm not sure adding a flag to the config class (which is meant just for model parameters) is the best way though.

I think changing the log.warning call to a log.debug one should suffice and will be useful if users run into issues, while avoiding flooding the terminal. I'll try it myself over the next couple days and update the PR.

If you have any other suggestions, feel free to post them here of course!

AlbertDominguez commented 6 months ago

I'm closing this PR as I've just fixed it with a commit to main. I simply changed the log.warning to log.debug so users can still efficiently debug if there are problems with this parameter. I'll release to PyPi on Monday!