search

weiks / quarters-unity-sdk

9 stars 8 forks source link

move logic before calling On functions #21

Closed paulofer85 closed 2 years ago

paulofer85 commented 2 years ago

delete try catch due to SendAttributionEvent doesn't throw error

Unity team detected: In QuartersSDK MakeTransaction() method yields back before the callbacks are called.

paulofer85 commented 2 years ago

On MakeTransaction the try-catch block was removed due to VspAttribution does not throw errors it fails silently https://github.com/weiks/quarters-unity-sdk/blob/01bcd449cda06f7b639925b5be8a6a30f7c4c5c8/Packages/gg.poq.unity.sdk/Runtime/QuartersSDK/Libs/VSPA/VspAttribution.cs#L91-L95

unitydevelopers-greg commented 2 years ago

Analytics events should fail silently.

paulofer85 commented 2 years ago

Analytics events should fail silently.

Yes in that case it won't be necessary the try/catch because it does not throw it only returns return AnalyticsResult.AnalyticsDisabled;