weiminye / elmah

Automatically exported from code.google.com/p/elmah
Apache License 2.0
0 stars 0 forks source link

Change query parameter "id" to something more likely to be unique. #114

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Change the errorId query parameter "id" to something more likely to be 
unique among an applications various HTTP modules.

This would achieve easier integration of ELMAH into applications using 
HTTP modules from different sources.

Original issue reported on code.google.com by madsst...@gmail.com on 4 Jun 2009 at 5:00

GoogleCodeExporter commented 9 years ago
i want to change my id 

Original comment by svsachin...@gmail.com on 11 Aug 2009 at 3:45

GoogleCodeExporter commented 9 years ago
I know this is a long, long time since this was raised, but can you be more 
specific about what you are requesting here please?

Original comment by jamesdriscoll71 on 24 Feb 2012 at 2:08

GoogleCodeExporter commented 9 years ago
Hi,

As I remember, it was an issue with using Elmah in a solution with the 
EPiServer CMS. EPiServer also use a query parameter "id" for referring a page 
in the CMS.
So there was a collision because HTTP-modules in both Elmah and EPiServer 
wanted to "own" that parameter, and messed things up.
Having a less generic name than "id" would make that collisions less likely to 
happen.

Mads

Original comment by madsst...@gmail.com on 24 Feb 2012 at 2:20

GoogleCodeExporter commented 9 years ago
Hi Mads,

Thanks for the quick response...
I'm a little confused in terms of an httpModule "owning" a query parameter 
though.

Unfortunately, I have no knowledge of EPiServer - have you got any further 
details / links to docs that may help?

Also, is this still an issue for you, or has it gone stale?

Cheers,

James

Original comment by jamesdriscoll71 on 24 Feb 2012 at 2:45

GoogleCodeExporter commented 9 years ago
Hi,

In an outgoing response, our CMS would rewrite an internal URL like 
"/template.aspx?id=123" to an external URL like "/mypage", so the CMS would 
"consume" the "id" parameter in the URL.
Something similar happening for the incoming request.

I think the problem was when trying to view a specific error in the Elmah error 
list. "elmah.axd/detail?id=123". Then our CMS would "consume" the "id" 
parameter in the URL and confuse Elmah.

We ended up not using Elmah on that project, but I know some of my colleagues 
are now using Elmah in another solution with the same CMS, so they probably 
found a way around it.

Mads

Original comment by madsst...@gmail.com on 24 Feb 2012 at 3:30

GoogleCodeExporter commented 9 years ago
Thanks Mads!

I understand now what you mean...
Sounds like it's a bit of an edge case that is no longer needed...
And should possibly have been dealt with on the CMS front anyway.
After all, who's to say that another CMS might not rewrite 
elmah.axd/detail?elmahid=123 into something else too!!

So I'm closing this as Wont-Fix (unless you can think of a pressing need for it 
to be re-opened)!

Thanks once again for spending the time to fill us in our your issue after we 
sat on it for so long!

Cheers,

James

Original comment by jamesdriscoll71 on 24 Feb 2012 at 3:41