search

weiquu / pe

0 stars 0 forks source link

Lack of standardisation between indices and days #5

Open weiquu opened 2 years ago

weiquu commented 2 years ago

01 and 02 can be used for indices but not for days - since they are both looking for positive integers, it makes sense to decide whether or not to allow or disallow this behaviour for both parameters.

soc-se-bot commented 2 years ago

Team's Response

Thanks for the feedback!
Since no screenshots were provided, the issue here is quite unclear, but if we were to make a guess, the main concern here is about the difference in the behaviour of the INDICES and DAY(S) parameters right?
To address your concern, the team refers you to the Command Syntax section in our User Guide. DAY(S) only accepts the integers 1 - 7, while INDICES can be any positive integer, which includes the possibility of integers with more than 1 digit. Therefore, this is not a bug, but rather a deliberate decision by the team.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: My apologies for the lack of screenshots. Your guess is correct, but I don't think that the response adequately explains away the bug.

From a user perspective, 01 and 02 are still part of the set of integers from 1 to 7. Hence, DAY(S), as a parameter that only accepts integers from 1-7, should accept these inputs. However, it does not. If the issue is that 01 and 02 have leading 0s, then it makes sense for INDICES to not accept these inputs as well. However, INDICES does accept these inputs, hence there is a lack of standardisation between these 2 commands that should be there.

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: According to the CS2103 website, a but of severity VeryLow is purely cosmetic and does not affect usage. However, this bug does affect usage, albeit in rare situations and only causes minor inconveniences. Hence, it fits the severity level of Low.