search

weiran-zsd / dts-cli

Zero-config CLI for TypeScript package development
MIT License
440 stars 23 forks source link

Running example folder with 2.0.0 fresh lib produce [vite] Internal server error: failed to resolve "extends":"@tsconfig/create-react-app/tsconfig.json" in example/tsconfig.json #194

Closed leobastiani closed 1 year ago

leobastiani commented 1 year ago

To reproduce

npx dts-cli create mylib --template react
cd mylib
yarn build
cd example
yarn
yarn start
yarn run v1.22.19
$ vite
▲ [WARNING] Cannot find base config file "@tsconfig/create-react-app/tsconfig.json" [tsconfig.json]

    tsconfig.json:2:13:
      2 │   "extends": "@tsconfig/create-react-app/tsconfig.json"
        ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  VITE v4.2.1  ready in 642 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h to show help
11:28:11 AM [vite] Internal server error: failed to resolve "extends":"@tsconfig/create-react-app/tsconfig.json" mylib/example/tsconfig.json

Could it be possible update example folder and use typescript 5 on it?

Thank you ❤️

aladdin-add commented 1 year ago

Thanks for letting me know. to fix it, you can just replace it with @tsconfig/vite-react/tsconfig.json.

I'll push a fix soon.

leobastiani commented 1 year ago

thank you ❤️ what do you think of adding a pipe line to test example folder?

aladdin-add commented 1 year ago

sure, that's' exactly what I'm thinking. Would you like to make a PR?

leobastiani commented 1 year ago

sure, I'll manage to do I also think it should be nice setting fixed versions of all packages in usage and updating then everyday automatically if no errors were found what do you think?

could you make this quick fix and then I could help with others more elaborated?

Em dom, 16 de abr de 2023 23:49, 唯然 @.***> escreveu:

sure, that's' exactly what I'm thinking. Would you like to make a PR?

— Reply to this email directly, view it on GitHub https://github.com/weiran-zsd/dts-cli/issues/194#issuecomment-1510612219, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCDAFNRR2IQLLXQXFMKEALXBSVU7ANCNFSM6AAAAAAXAFA6HI . You are receiving this because you authored the thread.Message ID: @.***>

aladdin-add commented 1 year ago

I also think it should be nice setting fixed versions of all packages in usage and updating then everyday automatically if no errors were found what do you think?

sounds good to me! 👍