search

weiran / Hackers

Hackers is an elegant iOS app for reading Hacker News written in Swift.
http://weiran.co/hackers
MIT License
697 stars 110 forks source link

Add setting to enable/disable swipe actions #202

Closed ballwood closed 3 years ago

ballwood commented 3 years ago

First of all - love the app, great work! I use it basically every day and its awesome that its open source too to modify.

Had a few issues with swipe actions accidentally upvoting comments and posts for me when using the app. This PR adds a item on the settings page to enable/disable these actions on my fork that I side load myself, don't know wether its useful to you to merge.

I'm not a huge swift/iOS expert (first PR) so feel free if you want to merge the PR to suggest some changes and I'll do them.

weiran commented 3 years ago

Hi @ballwood,

Thanks for your contribution! I agree this is a nice setting to have, especially since I added context menus with voting actions on a long press on the feed view.

However since I haven't added context menus to comments yet, I'll merge your PR into a swipe-settings branch and merge it into master once I add context menus to comments.

ballwood commented 3 years ago

@weiran cool! look forward to it being released, thanks 😊