search

weiran / Hackers

Hackers is an elegant iOS app for reading Hacker News written in Swift.
http://weiran.co/hackers
MIT License
697 stars 110 forks source link

Feedback button not working #207

Closed mulhoon closed 2 years ago

mulhoon commented 3 years ago

The feedback button doesn't seem to work in the settings.

I don't have mail on my phone if that helps. Just gmail.

noloman commented 3 years ago

I just tried and it works perfectly

mulhoon commented 3 years ago

What is the expected behaviour? What application is it meant to open?

I'm on iPhone XR without the Apple mail app.

rsponholtz commented 3 years ago

Feedback button doesn’t do any thing on my iPhone or iPad.

delreluca commented 2 years ago

Opens a dialogue from the mail app for me, so if you don't have it or don't have any accounts set up it won't work. See also the corresponding code: https://github.com/weiran/Hackers/blob/eeef782bec2f7d3f703a77e58b6c501afa0e47cb/App/Settings/SettingsViewController.swift#L121

mulhoon commented 2 years ago

Not ideal, for all those who don't use apple mail. Ideally use the mailto:// scheme https://stackoverflow.com/questions/54350041/mfmailcomposeviewcontroller-cansendmail-always-returns-false