search

weiran / Hackers

Hackers is an elegant iOS app for reading Hacker News written in Swift.
http://weiran.co/hackers
MIT License
697 stars 110 forks source link

add switch to explicitly enable and disable dark mode #211

Closed noloman closed 2 years ago

noloman commented 3 years ago

Simulator Screen Shot - iPhone 8 - 2021-08-26 at 12 57 45

mulhoon commented 3 years ago

Nice. Would there need to be 3 options... system, light and dark? Does this still work with following the system setting?

Thanks Nic

noloman commented 3 years ago

Nice. Would there need to be 3 options... system, light and dark? Does this still work with following the system setting?

Thanks Nic

Updated!

I see there's a previous commit with this feature but somewhere along the way. it was disabled and/or removed. Perhaps @weiran knows why? Thanks!

mulhoon commented 3 years ago

Hi, Sorry, Dark theme should probably just be Theme.

weiran commented 3 years ago

I removed this feature a while ago when I ripped out the old theme system around iOS 13, and never tried to add it back in. @noloman I like the switch based UI for selecting the theme option here, however I've found a few bugs with your implementation:

noloman commented 3 years ago

Hi hi,

I’d swear I had tested all that and it worked but I will work on it again will let you know, thanks!

El El vie, 22 oct 2021 a las 12:32, Weiran Zhang @.***> escribió:

I removed this feature a while ago when I ripped out the old theme system around iOS 13, and never tried to add it back in. @noloman https://github.com/noloman I like the switch based UI for selecting the theme option here, however I've found a few bugs with your implementation:

  • the setting doesn't persist after app restart
  • the toggle itself doesn't show the right selection when you reopen the settings screen

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/weiran/Hackers/pull/211#issuecomment-949497682, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMXYBLMQZ4U65PWSKZC7DUIE4TFANCNFSM5C23MQZQ .

weiran commented 2 years ago

Closing for now.