Added swipe action to share comment chain.

weiran / Hackers

Hackers is an elegant iOS app for reading Hacker News written in Swift.

http://weiran.co/hackers

MIT License

697 stars 110 forks source link

Added swipe action to share comment chain. #212

Closed jalxp closed 3 years ago

jalxp commented 3 years ago

Hi, wanted to contribute to some open source project, and found this lovely gem! First time contributing too!

After looking at some of the open issues, I noticed this one https://github.com/weiran/Hackers/issues/205 and decided to give it a try.

Basically just added a new swipe action to open up a UIActivityViewController with the link for the comment chain in question. 02 png

weiran commented 3 years ago

Hi @JalxP,

Thanks for the contribution! This is a nice simple addition that seems it should've always been there. The only downside is these links can't be opened by Hackers as it doesn't support redirection to comments, but happy to have the share sheet here anyway.

weiran commented 2 years ago

@JalxP wanted to let you know that I changed this before release - I'm going to keep the swipe action items to just collapse for comments as adding another item extends the amount you have to swipe to trigger the default collapse action.

Instead I've added a share comment action in the context menu if you long press on a comment.