Remove URL from title and SwiftLint from homebrew for apple silicon

weiran / Hackers

Hackers is an elegant iOS app for reading Hacker News written in Swift.

http://weiran.co/hackers

MIT License

692 stars 109 forks source link

Remove URL from title and SwiftLint from homebrew for apple silicon #249

Closed SR42 closed 1 year ago

SR42 commented 1 year ago

Hi! I really enjoy reading HN with your app and would like to propose a few fixes. The first one: title variable should not contain URL. I double-checked the app in simulator, now titles are correct . The second fix: I use Apple Silicon machine and I had to fix SwiftLint sh script as described in https://github.com/realm/SwiftLint#xcode. Hope that helps!

weiran commented 1 year ago

Reopening, didn't realise this PR targeted the titlefix branch.

weiran commented 1 year ago

Thanks @SR42 for the fix to HTML parsing! I also completely forgot that when I removed Cocoapods which pulled in SwiftLint the build script would need updating.

Appreciate it.