weiran / Hackers

Hackers is an elegant iOS app for reading Hacker News written in Swift.
http://weiran.co/hackers
MIT License
697 stars 111 forks source link

Reply to comments #93

Open weiran opened 5 years ago

mmangione commented 4 years ago

I love this app. Happy to jump in and help out. Where does this feature stand?

PerpetualCreativity commented 2 years ago

I think we first need to think of how we want to trigger this action. Swiping and tapping on comments already has a meaning. Should we bind adding a comment to a long-press action?

jalxp commented 2 years ago

@PerpetualCreativity I've seen more than one action on each swipe around for stuff like this. Take as an example the Apollo app for reddit, which looks pretty smooth. Nowadays most users expect a contextual menu on long presses as that's what natively happens on iOS. Unless you are suggestion adding this exact menu where one of the entries is the reply! 😄

PerpetualCreativity commented 2 years ago

@JalxP I completely forgot about those kinds of swipe actions, and was talking about the contextual menu. (Another example of multiple actions on a swipe is the Mail app with default settings, by the way.) I think your idea, of adding reply as an additional swipe action, is the best solution.

ktechmidas commented 2 years ago

@PerpetualCreativity As a user who didn’t know we couldn’t reply yet here’s what I did in order to try to find it

ErikThiart commented 2 years ago

Why not let user long press on the comment they want to reply to.

Easy peasy

Long Press, menu pops up, Reply

Tap reply,

Write reply

wesley-harding commented 1 year ago

Being a bit blunt. This thread has become a bit of bike shedding; focusing on the gesture to initiate reply rather than how we make it work technically. Wiring up the trigger action is the the easiest part of this feature.

I really enjoy this app, but without comments I'll end up using another app.

I'm guessing we need to do the following to make this work:

Bonus