weirdNox / org-noter

Emacs document annotator, using Org-mode
GNU General Public License v3.0
1.07k stars 101 forks source link

fix: save point before making frame in case it moves. #165

Open 2e0byo opened 2 years ago

2e0byo commented 2 years ago

org-noter stopped working for me recently and I traced it to create-frame modifying point (specifically, moving it to the end of the buffer). This causes a subsequent call to org-noter--parse-root to fail since it's on the the wrong part of the buffer.

I don't see anything in the release notes about make-frame no longer being idempotent. It could be something happening in a hook this end, but I've not got the time to look into it at the moment. But in any case I can't see any harm in setting current-pos before calling make-frame, which ensures this works even on potentially broken systems.

NB I realise this repository is basically abandoned, but there doesn't seem to be a definitive fork so I'm dropping it here in case anyone else has this problem.