search

weirdNox / org-noter

Emacs document annotator, using Org-mode
GNU General Public License v3.0
1.08k stars 101 forks source link

org-noter creates a new frame despite setting org-noter-always-create-frame to nil #170

Closed jingxuanlim closed 2 years ago

jingxuanlim commented 2 years ago

Hello. I just tried to implement a journal article note-taking workflow that I read about in this guide. Whenever I start M-x org-noter from an org file, I expect my frame to be split into two windows. However, a new frame is created. This is unexpected behavior, as I understand that setting org-noter-always-create-frame to nil should prevent this.

Here's what I think is the relevant block of code (taken straight from the tutorial).

(use-package! org-noter
  :after (:any org pdf-view)
  :config
  (setq
   ;; The WM can handle splits
   org-noter-notes-window-location 'other-frame
   ;; Please stop opening frames
   org-noter-always-create-frame nil
   ;; I want to see the whole file
   org-noter-hide-other nil
   ;; Everything is relative to the rclone mega
   org-noter-notes-search-path (list org_ref_notes)
   )
  )

Not sure if this is relevant, but I'm running Ubuntu 20.04 on WSL2 and forwarding GUI Emacs via VcXsrv.

Any help from anyone would be appreciated. Thanks!

jingxuanlim commented 2 years ago

Sorry, I realized my mistake. I didn't read the documentation and just tried to copy someone else's config without also fully understanding what the behavior of their config is. Setting org-noter-notes-window-location to horizontal-split fixed it for me.