search

weirdNox / org-noter

Emacs document annotator, using Org-mode
GNU General Public License v3.0
1.07k stars 101 forks source link

work with org-attach #66

Closed shelper closed 5 years ago

shelper commented 5 years ago

now if i run org-noter on a headline, it ask for the path for the pdf file but org mode actually come with org-attach, which would be useful if org-noter automatically find the attached file and i dont have to type any more is this an easy feature to add?

weirdNox commented 5 years ago

This has been on my backlog for quite some time, thanks for reminding me!

I don't think it would take too much time to do that, but I am a bit short on time currently, so it will take some time until it is implemented :/

rosetree commented 5 years ago

This would probably also enhance the combination with org-brain, which supports attachments from the visualized setting.

What would you do about multiple attachments? Should the first selection add a document property or should the attachment always be selected again? Both seem to be useful. The second approach is not as fast for future noter sessions, but allows to share notes between different versions of a document.

weirdNox commented 5 years ago

I was thinking of asking which file we wanted to use as document, on the first run, and saving that as NOTER_DOCUMENT; then it would work as it works now.

I wasn't planning on supporting multiple documents because, even with versions of the same document, it could change significantly, having the same content on different pages, which would make org-noter useless (at least with my type of annotations, see fuxialexander/org-pdftools).

However, I could also implement a function that lists once again the different attachments, and changes NOTER_DOCUMENT accordingly before calling org-noter, which you could use to override the version you're seeing.

weirdNox commented 5 years ago

I believe this is done! Please test it and report back :)

Also, if you want to choose another attached file, use 2 universal prefix arguments when executing org-noter, which overrides the annotated document. You could write a wrapper for that, if you use it a lot.

rosetree commented 5 years ago

Thanks, @weirdNox! It works great in combination with org-brain. This is a fantastic feature :)

yiufung commented 4 years ago

Just to say this is really really useful feature and thanks for working on it! Discovering org-attach and org-noter individually have given me so much help, and combining them is just magnificence at another level. This could've been in README for more attention. Thanks again for the great work!

weirdNox commented 4 years ago

I always forget to add new features to the README! :D Thanks for the kind words and for the reminder :)