weirdNox / org-noter

Emacs document annotator, using Org-mode
GNU General Public License v3.0
1.07k stars 101 forks source link

pdf-tools error though it's installed #78

Closed Nathan-Furnal closed 5 years ago

Nathan-Furnal commented 5 years ago

Hi all,

I'm currently using emacs 26.1 on Ubuntu 19.04 and I install packages using MELPA.

When I click 'Install' on org-noter after list-packages I get the following error :

org-noter-integration.el:2:1:Error: Cannot open load file: No such file or directory, org-pdftools

But I do have pdf-tools installed. More, the package is written as "installed" afterwards.

weirdNox commented 5 years ago

Oh no, that's a mistake I made when integrating a pull request recently, I thought that file wouldn't be included in the package! I'll fix it, in a few hours try again please :)

weirdNox commented 5 years ago

Also, even though it gives that error installing, you may probably use org-noter anyway, as it is on a different file

Nathan-Furnal commented 5 years ago

Sure thing ! Thanks for heads-up. Do you want me to close it or do you want to add it to a PR ?

weirdNox commented 5 years ago

I believe commit 73a6c85dcdb6579d7ff183558a5be580926ce043 fixes this. After MELPA rebuilds the package, try to upgrade and see if it works. Then, please, close or comment depending on whether or not this works :)

Nathan-Furnal commented 5 years ago

All good thank you !