weirdgloop / mediawiki-extensions-RSHiscores

Provides easy access to RuneScape's Hiscores for use in wikitext and JS calculators.
GNU General Public License v3.0
1 stars 2 forks source link

Adapting to the .json endpoint #1

Open DrYoshiyahu opened 2 weeks ago

DrYoshiyahu commented 2 weeks ago

Recently, Jagex offered a .json endpoint for the hiscore API, which obviously comes with a great deal more information that makes parsing the data much much simpler and straightforward. Because the json data gives names for each skill and boss/minigame, it doesn't require pre-knowledge of the arbitrary order the data appears in, as opposed to the .ws endpoint that was historically used, which just gives a list of numbers without context, and must be sorted by the user.

I suggest changing this extension to use the json endpoint, or at least offering an option to do so. It will dramatically simplify the process for anyone wanting to use the data, and in doing so, will make it more accessible for more people to use the data in creative ways.

https://secure.runescape.com/m=hiscore_oldschool/index_lite.ws?player=DrYoshiyahu https://secure.runescape.com/m=hiscore_oldschool/index_lite.json?player=DrYoshiyahu

pjoeterbliep commented 2 weeks ago

Please merge: https://github.com/weirdgloop/mediawiki-extensions-RSHiscores/pull/2

pjoeterbliep commented 1 week ago

Please merge https://github.com/weirdgloop/mediawiki-extensions-RSHiscores/pull/3 instead of https://github.com/weirdgloop/mediawiki-extensions-RSHiscores/pull/2