search

weirdgloop / mediawiki-extensions-RSHiscores

Provides easy access to RuneScape's Hiscores for use in wikitext and JS calculators.
GNU General Public License v3.0
1 stars 2 forks source link

Add json endpoint for hiscores #2

Closed pjoeterbliep closed 2 months ago

pjoeterbliep commented 3 months ago

Tested it, seems to work.

DrYoshiyahu commented 3 months ago

Amazing! What a quick turnaround! <3

leejt commented 2 months ago

Is there a reason we want to support both endpoints? Can you just replace the existing functionality rather than supporting both json and ws?

wgevaert commented 2 months ago

Backwards compatibility mostly. You dont want all tools to break when we deploy this right?

Or maybe you do

Code would for sure be simpler if we allow only one endpoint

pjoeterbliep commented 2 months ago

I made a pull request that breaks backwards compatibility here, it also fixes issue 1. We can merge one of the two and close the other.

DrYoshiyahu commented 2 months ago

I think it's completely fine to break backwards compatibility and forget the ws endpoint. There are so few tools that actually use this plugin, and it's a very easy fix.

pjoeterbliep commented 2 months ago

Closed in favor of https://github.com/weirdgloop/mediawiki-extensions-RSHiscores/pull/3 Consensus seems to be to break backwards compatibility while implementing this feature, which is what that pull request does