js: update combobox overlay to use SDRedirectDialog's rather than default

weirdgloop / mediawiki-extensions-SearchDigest

Displays the most popular failed wiki searches in a special page, Special:SearchDigest.

GNU General Public License v3.0

1 stars 7 forks source link

js: update combobox overlay to use SDRedirectDialog's rather than default #1

Closed 1bakedpotato closed 1 year ago

1bakedpotato commented 1 year ago

since SDRedirectDialog is a modal, trying to use the default overlay will cause its contents to be uninteractable since OOUI will "isolate" everything that isn't contained within the modal's window manager.

basically, follow the instructions at https://www.mediawiki.org/wiki/OOUI/Concepts#Overlays:

For elements inside dialogs, you should use the dialog's this.$overlay property.