NPC-vs-player damage

[leejt]

Compute NPC-on-offense vs player-on-defense combat.

Extremely hard to do in general because we don't understand boss attack mechanics very well, but probably can get useful answers for about 80% of monsters without all that much effort

Hard parts:

• How to make it extremely clear that it won't work very well for "complicated" monsters?
• Which metrics (DPS, max hit, total damage taken, etc) do we display in the output section? Presumably all are fair game for graph y-axis
• Getting protection prayers right would go a long way (but do we want these in the prayer UI?)
• General UI bloat for defensive-minded inputs could get to be frustrating when they are irrelevant for ~95% of users

Discussed in some detail here

---

Implementation (PR: #201)

• [x] Calculate NPC's max hit (based on linear dist), attack roll, accuracy, DPS
• [x] Calculate player's def roll
• [x] Calculate damage taken per kill (Player TTK * NPC DPS)
• [x] Show warnings for complex monsters
• [x] Support defensive prayers, including 5/10/15% def prayers in the player def roll calc
• [x] Add defence potions to potion UI

Support common special cases

• [x] Passive effect of elysian spirit shield
• [x] Passive effect of justiciar armour
• [x] Passive effect of dinh's bulwark
• [x] Passive effect of Torag's set + AOTD
• [ ] Dragonfire protection
• [ ] Ward of Arceuus damage reduction for demonic creatures
• [ ] Protection prayers (easy to do in general, but need to make sure we're pretty confident that we've accounted for all the use cases where enemies can still hit through them)

Support niche special cases

• [ ] Passive effect of neitiznot shield
• [ ] Passive effect of snelms

[SuperNerdEric]

Some more special cases to consider. Some of these depend on more complex things being implemented first.

• [ ] Staff of the dead / Toxic staff of the dead / Staff of balance / Staff of light special attack halves all of the opponent's melee damage
• [ ] Insulated boots reduce damage from Killerwatts and Rune dragons
• [ ] Witchwood icon- The special scream attack from cave horrors is guaranteed to deal 10% of the player's total Hitpoints in damage when the icon is not worn. The icon does not negate all damage from the scream, it instead causes the scream attack to roll as a regular attack.
• [x] Aberrant spectre - nose peg / slayer helm
• [x] Sourhogs - Reinforced goggles / slayer helm
• [ ] Earmuffs - used to protect against banshees' screams and to reduce damage from warped terrorbirds (unclear how much?)
• [x] Wall beast - Spiny helmet
• [ ] Fever spider - Slayer gloves
• [x] Facemask - Dust devil

[SuperNerdEric]

On warped terrorbirds https://twitter.com/JagexAsh/status/1754800191910072403

[SuperNerdEric]

Not sure if this was well known about dragons: https://twitter.com/JagexAsh/status/1755605769029075288