search

weirdgloop / osrs-dps-calc

Web-based DPS calculator for Old School RuneScape
GNU General Public License v3.0
30 stars 39 forks source link

Ice Ancient Sceptre not calculated #235

Open matthewpetch opened 9 months ago

matthewpetch commented 9 months ago

What went wrong?

Accuracy roll is identical when using Ice Barrage regardless of whether the Ice variant of the sceptre is selected or not

example: https://dps.osrs.wiki/?id=SledSanfewSpine

What did you expect to happen?

I believe the accuracy difference should be 0.4% (could be wrong)

What browsers are you seeing the problem on?

Firefox, Chrome

What device(s) are you seeing the problem on?

Windows, Other

Any other information

No response

SuperNerdEric commented 9 months ago

https://oldschool.runescape.wiki/w/Ice_ancient_sceptre

Something to be careful about when implementing this is "10% accuracy bonus given to ice spells on targets that can be frozen and are not currently frozen." which is something that I'm not really sure can 100% be accounted for in calculating DPS on a target.

  1. We need to define a list of monsters that can be frozen
  2. We need to account for the fact that the 10% bonus is only on monsters that aren't currently frozen
  3. We need to account for the fact that even with the 10% bonus you may miss your freeze and get multiple attacks with the bonus
  4. We need to account for a monster eventually becoming unfrozen

These seems like a really hard problem to properly solve without a full simulation. It might be better to just put in a warning and show the player both possible accuracy rolls / percent.