weirdgloop / osrs-dps-calc

Web-based DPS calculator for Old School RuneScape
GNU General Public License v3.0
25 stars 25 forks source link

Ahrims mark of darkness fixes #362

Closed jmyaeger closed 1 month ago

jmyaeger commented 1 month ago

Addresses #301

I did some testing in-game to verify that a) mark of darkness is applied post-roll and b) it is applied before the ahrim's + amulet of the damned effect.

Here is a hit distribution I collected in-game that verifies post-roll behavior for mark of darkness. image

And here is a max hit I got using mark of darkness + ahrim's set effect on a demon. I was using superior demonbane with 8% gear bonus, meaning my base max hit was 24. If ahrim's were applied first, the max hit would first be trunc(24 * 1.3) = 31, and then trunc(31 * 1.25) = 38. The max hit is 39, proving that the order is actually trunc(24 * 1.25) = 30 -> trunc(30 * 1.3) = 39.

image