Amulet of avarice bonus applied incorrectly.

[EnuDelrum]

What went wrong?

At least when it comes to magic damage, the Amulet of avarice bonus against revenants it being incorrectly applied after the magic damage bonus instead of being added with the magic damage bonus.

For example, putting this in the DPS calc (with Fire Surge and 99 Magic) you'd expect a max hit of 33. https://dps.osrs.wiki?id=SlacksFiveLumber

In-game it actually hits for 32.

Example of what's happening:

And (for what it's worth) this is how it fits into all of the magic damage max hit calculations (not including non-pvp tomes):

What did you expect to happen?

No response

What browsers are you seeing the problem on?

Chrome

What device(s) are you seeing the problem on?

Windows

Any other information

It seems like Forinthry Surge is correct as it's just changing the avarice's bonus from 20% to 35%.

[jmyaeger]

Just FYI, your magic max hit model is slightly inaccurate. Ahrim's + amulet of the damned is a post-roll effect that occurs after the mark of darkness boost, and the tomes were changed to be multiplied in at the end of the pre-roll calculation rather than post-roll.

Also, re: accursed sceptre's interaction with the slayer boost, have you tested that in-game to confirm that the two boosts are additive? They're implemented as multiplicative (slayer first, then sceptre) in the calc at the moment, so it would be good to know if that's wrong.

[EnuDelrum]

@jmyaeger Thank you for the info. I know my tomes were still wrong since the update. But I spent the weekend doing some thorough testing. You were right about Ahrim's + amulet of the damned being post-roll. It was hard for me to verify since there's no indication if you're getting a higher hit without the effect or a lower hit with the effect triggering. Testing this with mark of darkness, I looked at if they're additive or multiplicative along with which is multiplied first. The numbers match the mark of darkness and then the 30% amulet bonus (when it rolls) being multiplicative in that order. And of course, both are happening post-roll.

You're also correct that after the initial magic damage bonus (such as gear, prayer, etc) that slayer, thammaron's/accursed sceptre and tomes are each multiplicative in that order. Accursed sceptre is also multiplicative with its special attack.

I checked all of these on the DPS calc. Besides this bug report for the amulet of avarice, everything else matched up with the in-game numbers. I've updated my spreadsheet too.