search

weirdpattern / gatsby-remark-embed-gist

Gatsby remark gists preprocessor
MIT License
30 stars 15 forks source link

Defering CSS loading #26

Closed brunosabot closed 4 years ago

brunosabot commented 4 years ago

Hi,

this PR is here to solve the #24 issue. The solution is based on https://web.dev/defer-non-critical-css/

codecov-commenter commented 4 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #26   +/-   ##
=======================================
  Coverage   97.77%   97.77%           
=======================================
  Files           2        2           
  Lines          45       45           
  Branches       15       15           
=======================================
  Hits           44       44           
  Misses          1        1
Impacted Files Coverage Δ
src/gatsby-ssr.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7668ac3...f86a50c. Read the comment docs.

brunosabot commented 4 years ago

Hello @weirdpattern! Is there anything missing/wrong I can fix?

weirdpattern commented 4 years ago

Hi @brunosabot no, everything is fine. Sorry I didn't get to this sooner. I will merge now and publish tonight.

brunosabot commented 4 years ago

Awesome thanks!

santiq commented 4 years ago

@weirdpattern Hi there! Can you publish this update? Thanks!

weirdpattern commented 4 years ago

Hey @santiq I'm working on this tonight, but some of the tests are failing for me, so I'm reviewing the merged commits. I will post another update in a few hours.

Sorry for the delay... I've work in healthcare and things are going crazy at work.

weirdpattern commented 4 years ago

All right people, v1.1.10 is finally out.

I apologize for the long wait, hopefully the wait will be worth it. Reach out to me if you have questions comments or concerns.