search

weirongxu / coc-explorer

📁 Explorer for coc.nvim
MIT License
1.14k stars 45 forks source link

feat: add "explorer.enable" option #478

Closed yaegassy closed 3 years ago

yaegassy commented 3 years ago

Description

Due to the nature of coc-explorer, it outputs a lot of logs in :CocInfo and coc debug logs.

I'm developing some coc extensions, I uninstall coc-explorer every time I want to check other coc extensions in detail.

I thought it would be useful to have an option to enable/disable.

Misc

If you do not intend to provide the enable/disable option, you can close this PR. 🙇

weirongxu commented 3 years ago

Have you tried using the CocAction("toggleExtension") to disable the extension?

yaegassy commented 3 years ago

I have never used CocAction("toggleExtension").

weirongxu commented 3 years ago

It occurred to me that using CocAction("toggleExtension") would avoid frequent uninstall/install of a extension

weirongxu commented 3 years ago

Another way to trigger toggleExtension is to use CocList extensions and disable a extension

weirongxu commented 3 years ago

I should use the explorer.debug option to avoid printing too many logs, I'll change the explorer.debug option behavior later, if you think it's still worth adding an explorer.enable option, you can express your opinion

yaegassy commented 3 years ago

I don't use enable/disable in :CocList extension. Since I don't use it all the time, you might misunderstand its current state.

Since @weirongxu seems to think that the enable option is unnecessary, I will close this PR.

Thanks! 🙇

yaegassy commented 3 years ago

I think it may not be possible to enable/disable at the "workspace level" with the :CocList extension.

However, there may not be a case where you want to enable/disable coc-explorer at the workspace level, so no problem!

Once again, thanks!