weirongxu / coc-explorer

📁 Explorer for coc.nvim
MIT License
1.14k stars 45 forks source link

Search always ignores .ignore file #482

Closed notpeelz closed 3 years ago

notpeelz commented 3 years ago

The search function passes showIgnore: true to the files ListTask, which forces fd to ignore .ignore, .fdignore and .gitignore.

Is this intentional? It would be nice if the user had control over that setting.

weirongxu commented 3 years ago

This is intentional, and I've made this the default behavior, because without ignoring .gitignore, the search function will search through a lot of node_modules or third-party or vendors folders, making it too slow. But we can also add an action argument to skip this limitation

notpeelz commented 3 years ago

I think you have it backwards. On my end, the search function lists a bunch of files from node_modules:

weirongxu commented 3 years ago

Indeed, you are right, perhaps this function should be changed to ignore node_modules by default

notpeelz commented 3 years ago

Couldn't you just set this to false?

weirongxu commented 3 years ago

I would like to have an option to possibly let the user control whether to ignore them or not, and I will add this feature as soon as possible.

notpeelz commented 3 years ago

Thanks!