Rework mechanism for disabling properties.

weisJ / auto-dark-mode

IDEA plugin to automatically apply system theme settings on macOS and Windows.

https://plugins.jetbrains.com/plugin/14076-auto-dark-mode

MIT License

53 stars 14 forks source link

Rework mechanism for disabling properties. #17

Closed weisJ closed 4 years ago

weisJ commented 4 years ago

The mechanism for controlling whether a property is active wasn't really desirable. This PR approaches the problem. It also allows for whole groups to be enabled/disabled through the addition of nested groups. The new mechanism made it possible to have the controls for whether the IDE/Editor theme is changed without much boilerplate code.

@IncPlusPlus Could you check, that the Gnome settings still behave as expected?

IncPlusPlus commented 4 years ago

Sure thing. I'll pull this tomorrow and let you know if everything is in order.

IncPlusPlus commented 4 years ago

Sorry for the long response time. I'm dual-booting Windows and Pop!_OS and the latter side has become unstable. I'm unable to boot into Pop for some reason. Sorry for the hold-up. I'll try this out as soon as is possible.

IncPlusPlus commented 4 years ago

Just managed to get into it again. Checked out this branch and pulled the changes. Theme guessing (the default) works as well as setting the themes manually. Graying out the GTK theme choices still occurs when the "Guess light/dark theme based on name" box is ticked. I also tested whether high contrast detection works and it behaved as expected. Everything looks good.