weisJ / auto-dark-mode

IDEA plugin to automatically apply system theme settings on macOS and Windows.
https://plugins.jetbrains.com/plugin/14076-auto-dark-mode
MIT License
53 stars 14 forks source link

Auto mode not working on macOS Big Sur #25

Closed feferka closed 1 year ago

feferka commented 3 years ago

Even OS has already day theme, it still switches IJ to dar, i.e. if manually moved to light theme, plugin switch it back to dark.

weisJ commented 3 years ago

Did you restart IJ after installing the plugin?

feferka commented 3 years ago

Indeed, many times. Tried to reinstall as well.

Sincerely Pavol


From: Jannis Weis notifications@github.com Sent: 24 November 2020 14:01 To: weisJ/auto-dark-mode auto-dark-mode@noreply.github.com Cc: Melicharek, Pavol pavol.melicharek@teliacompany.com; Author author@noreply.github.com Subject: Re: [weisJ/auto-dark-mode] Stoped working on Big Sur macOS and IJ 2020.2.3 (#25)

Did you restart IJ after installing the plugin?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/weisJ/auto-dark-mode/issues/25#issuecomment-732959248, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABCI7P2I3CYKD5ZAC6PFS43SROVD3ANCNFSM4UAU6FNQ.

This email may contain information which is privileged or protected against unauthorized disclosure or communication. If you are not the intended recipient, please notify the sender and delete this message and any attachments from your system without producing, distributing or retaining copies thereof or disclosing its contents to any other person.

Telia Company processes emails and other files that may contain personal data in accordance with Telia Company’s Privacy Policyhttps://www.teliacompany.com/en/about-the-company/privacy/.

weisJ commented 3 years ago

I haven't yet been able to test the plugin with macOS Big Sur and won't be able to do so for a while as I don't have access to a machine running it. I'll see what I can do, however without access to a Big Sur machine this won't be much. If possible I would highly appreciate if you could help me here.

feferka commented 3 years ago

Yesterday I rebooted my mac and looks it helped also to your plugin. It is back working automagically ... Sorry for false alarm.

Sincerely Pavol


From: Melicharek, Pavol pavol.melicharek@teliacompany.com Sent: 24 November 2020 14:05 To: weisJ/auto-dark-mode auto-dark-mode@noreply.github.com; weisJ/auto-dark-mode reply@reply.github.com Cc: Author author@noreply.github.com Subject: Re: [weisJ/auto-dark-mode] Stoped working on Big Sur macOS and IJ 2020.2.3 (#25)

Indeed, many times. Tried to reinstall as well.

Sincerely Pavol


From: Jannis Weis notifications@github.com Sent: 24 November 2020 14:01 To: weisJ/auto-dark-mode auto-dark-mode@noreply.github.com Cc: Melicharek, Pavol pavol.melicharek@teliacompany.com; Author author@noreply.github.com Subject: Re: [weisJ/auto-dark-mode] Stoped working on Big Sur macOS and IJ 2020.2.3 (#25)

Did you restart IJ after installing the plugin?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/weisJ/auto-dark-mode/issues/25#issuecomment-732959248, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABCI7P2I3CYKD5ZAC6PFS43SROVD3ANCNFSM4UAU6FNQ.

This email may contain information which is privileged or protected against unauthorized disclosure or communication. If you are not the intended recipient, please notify the sender and delete this message and any attachments from your system without producing, distributing or retaining copies thereof or disclosing its contents to any other person.

Telia Company processes emails and other files that may contain personal data in accordance with Telia Company’s Privacy Policyhttps://www.teliacompany.com/en/about-the-company/privacy/.

weisJ commented 3 years ago

Thank you for the information. I'll still leave the issue up as unreliability on macOS Big Sur may be possible, which needs investigation.

VincentJoshuaET commented 3 years ago

I confirm this.

  1. Turn on macOS automatic theme change
  2. If Android Studio is opened, then its theme will also change.
  3. Close Android Studio and shut down Mac.
  4. Turn on Mac, theme automatically changes from light to dark or dark to light.
  5. Open Android Studio. Theme is still the one before I closed Android Studio from step 2.

Workaround: Change the theme from System Preferences to Light or Dark and Android Studio will change the theme as well.

weisJ commented 3 years ago

I confirm this.

  1. Turn on macOS automatic theme change

  2. If Android Studio is opened, then its theme will also change.

  3. Close Android Studio and shut down Mac.

  4. Turn on Mac, theme automatically changes from light to dark or dark to light.

  5. Open Android Studio. Theme is still the one before I closed Android Studio from step 2.

Workaround: Change the theme from System Preferences to Light or Dark and Android Studio will change the theme as well.

Thank you for the reproduction steps. Because it's working when Auto mode isn't selected I can narrow down the cause of the issue to the following function:

https://github.com/weisJ/auto-dark-mode/blob/371e81c245a7733957ed0c0d00be43adb2d151e9/macos/src/main/objcpp/DarkModeMacOS.mm#L125

Some information that would be good to have is: