weiseng18 / pe

0 stars 0 forks source link

Error message is too generic for delete #14

Open weiseng18 opened 4 days ago

weiseng18 commented 4 days ago

image.png

image.png

The same error message for delete 3 could be used for delete 1

soc-pe-bot commented 11 hours ago

Team's Response

Screenshot 2024-11-18 at 11.02.35 AM.png

Hi, regarding this, our team have looked into the textbook and we think that delete -1 should be considered a format error, since the only allowed values are positive integers (just like the textbook example where the only allowed months are from 1 to 12), whereas delete 3 should be an input error since the list that you provided above only contains only 1 name (just like the textbook example where Feb 30 is considered an input error).

As we follow the textbook guidelines closely, we don't really see an issue with this. However, perhaps what you said also make sense, and maybe we could phrase the message better, but then, we would have a lot of different cases to check to give the right error message (e.g. What if the user inputs delete -1 like you did?, What if the user inputs delete abc then? In this case what would be the appropriate error message?). And for each of the cases, there will always be a more specific error message that you could give.

Hence, this is considered a better implementation that would take up a considerable amount of time, and delay other more important work we have in hand, and in this case, the system actually fails gracefully if the user tries inputting it, so we decide to quantify it as notInScope so that you can still get some credit as well for recognising this.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]