search

weissi / FRLayeredNavigationController

FRLayeredNavigationController, an iOS container view controller that works like a stack of paper with an API similar to UINavigationController.
Other
484 stars 61 forks source link

hasChrome affects grouped table background #21

Closed iOSDevil closed 11 years ago

iOSDevil commented 11 years ago

really great library you've got here

I was struggling to set the background of a grouped tableview to clear and noticed that the same code works when a FRLayeredNavigationItem hasChrome is set to NO. If hasChrome is set to YES then the tableviews background is grey

in my tablewviews viewdidload: [super viewDidLoad]; [self.tableView setBackgroundView:nil];

is there a quick fix for this please?

iOSDevil commented 11 years ago

you can probably ignore this "issue". I commented out [addsubview:self.borderview] in FRLayerController, this gave me the desired affect but at a big performance hit

weissi commented 11 years ago

Hi @iOSDevil ,

that's a bug and I'll fix it. Thank you very much for the hint!

Thanks, Johannes

weissi commented 11 years ago

Ah, as I see you have also identified the bug. It's that borderview but without the borderview there should be some minor visual regression. Therefore I'll leave the bug open and I'll fix it in the next days.

iOSDevil commented 11 years ago

Okey dokey, you're the boss

weissi commented 11 years ago

@iOSDevil, it's officially fixed now ;-).

If you don't like the borders there's a new property layeredNavigationItem.hasBorder = NO to turn them off. Usually you set hasBorder in a configuration:... block when pushing a new layer.

If there's anything that doesn't work, feel free to reopen this issue or open a new one.

Thanks!