search

weissi / swift-server-logging-api-proposal

SSWG Proposal for Logging API
9 stars 8 forks source link

Add "fault" log level #39

Closed ianpartridge closed 5 years ago

ianpartridge commented 5 years ago

There is consensus on the forum that we should add an extra logging level above error. Possible names for this include fatal or fault.

Add a fault log level. This name is chosen for consistency with os_log() which is already used in the Swift ecosystem.

ianpartridge commented 5 years ago

@weissi is there anything else I need to do to this?

weissi commented 5 years ago

@ianpartridge want me to merge this or are we waiting on https://forums.swift.org/t/logging-levels-for-swifts-server-side-logging-apis-and-new-os-log-apis/20365/11 which looks like syslog log levels?

ianpartridge commented 5 years ago

I totally missed that thread - it wasn't posted in the "server" category... Let me go read...

weissi commented 5 years ago

I totally missed that thread - it wasn't posted in the "server" category... Let me go read...

I know it's confusing because the previous discussions where in the server category but it's for os_log & the server API, therefore Ravi posted in the general category.

ianpartridge commented 5 years ago

OK I'm fine with syslog levels if this will improve interoperability. I do think there's value in the additional "trace = 8" level but we can handle that separately.

I think we should probably close this PR?