search

weixunjie / jquery-i18n-properties

Automatically exported from code.google.com/p/jquery-i18n-properties
0 stars 0 forks source link

Please don't override String.prorotype.split #21

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Doesn't seem like something a plugin should do. It seems like the override is 
only necessary for older browser support of spliting on regexes. You appear to 
be using this only in a single place: when splitting on new lines. You could 
just as easily split on the newline character rather than use a regex.

Then you can stop overriding the string method and also slim down the library.

Original issue reported on code.google.com by derekpr...@gmail.com on 10 Oct 2012 at 8:48