weiyhcarlos / trainning

0 stars 0 forks source link

pythonic #3

Closed valensc closed 8 years ago

valensc commented 8 years ago

以下是看到的一些

  1. if "ttl" in varDict.keys()
  2. while(True)
  3. def set_handler(self, params_dict): 参数表可以写成(self, config, method),调用时set_handler(**params_dict),保持接口可读性
  4. try catch中不要包含不必要的逻辑,例如:

           try:
               data[module]["time"] = data["time"]
               data[module]["machine_id"] = data["mac"]
               self.database[module].insert_one(data[module])
           except PyMongoError:
               self.store_local(module, data[module])
               error_info += ("upload " + module + " info fail.\n")
weiyhcarlos commented 8 years ago

@valensc 已更改:)