fix(CSI-241): disregard sync_on_close in mountmap per FS

[sergeyberezansky]

TL;DR

Introduced a new AsMapKey() method for MountOptions to create version-agnostic map keys.

What changed?

• Added a new AsMapKey() method to the MountOptions struct in mountoptions.go.
• This method creates a version of the mount options that excludes certain options (currently only MountOptionSyncOnClose) to be used as a map key.
• Updated mounter.go to use AsMapKey() instead of String() when accessing or modifying the mountMap.

How to test?

Covered by unit testing

Why make this change?

This change allows for more consistent handling of mount options across different versions of the Weka cluster / client. By excluding version-specific options like MountOptionSyncOnClose from the map key, we can avoid unnecessary duplication of mounts and ensure that mounts with the same essential options are treated as identical, regardless of version-specific differences.

---

[sergeyberezansky]

• #326
• #323
• #322
• #320
• #319
• #318
• #317
• #316
• #314
• #313
• #312
• #311
• #315
• #325
• #299
• #310 👈
• #324
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sergeyberezansky and the rest of your teammates on Graphite

[graphite-app[bot]]

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/02/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

[sergeyberezansky]

Merge activity

• Sep 12, 6:10 AM EDT: @sergeyberezansky started a stack merge that includes this pull request via Graphite.
• Sep 12, 6:18 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 12, 6:20 AM EDT: Graphite rebased this pull request as part of a merge.
• Sep 12, 6:25 AM EDT: @sergeyberezansky merged this pull request with Graphite.