Closed sergeyberezansky closed 1 month ago
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @sergeyberezansky and the rest of your teammates on Graphite
1 reviewer was added to this PR based on Sergey Berezansky's automation.
TL;DR
Added a new function to determine the node's IP address based on routing to a target host.
What changed?
GetNodeIpAddressByRouting
inutils.go
that determines the node's IP address by creating a UDP connection to a target host.doMount
function innfsmount.go
to use the newGetNodeIpAddressByRouting
function, falling back toGetNodeIpAddress
if it fails.GetNodeIpAddressByRouting
function inutils_test.go
.How to test?
utils_test.go
to verify the functionality ofGetNodeIpAddressByRouting
.GetNodeIpAddress
function ifGetNodeIpAddressByRouting
fails.Why make this change?
This change improves the accuracy of determining the node's IP address for NFS mounts, especially in complex network environments. By using routing information to determine the IP address, we can ensure that the correct network interface is used for NFS communications, potentially resolving issues related to multi-homed systems or specific network configurations.
feat(deps): implement InterfaceGroup.GetRandomIpAddress()
feat(deps): implement InterfaceGroup.GetRandomIpAddress()
refactor(deps): allow multimount for NFS
refactor(deps): unmount underlying FS straight after publishing volume